Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS for shelves #3013

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

RSS for shelves #3013

wants to merge 27 commits into from

Commits on Sep 29, 2023

  1. working rss feed for shelves

    mattkatz committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    856737e View commit details
    Browse the repository at this point in the history

  2. add a failing test for rss feeds for shelves 

    Currently can't get the test to succeed - it fails in an unrelated redis
error, so pushing this so I can open a draft PR to get advice on a better
test.
    mattkatz committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    4ae0dbd View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2023

  1. fix linting issue 

    didn't really need to add the shelf to self and the linter doesn't like
seeing it outside of an init or setup.
    mattkatz committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    c142e38 View commit details
    Browse the repository at this point in the history

  2. fixed method without docstring

    mattkatz committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    f665aea View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Mock activitystreams add_book_statuses_task

    mattkatz committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    339298c View commit details
    Browse the repository at this point in the history

  2. remove duplicate sitesettings error

    mattkatz committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    d3d5f1b View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Merge branch 'main' into rss-for-shelves

    @jaschaurbach
    jaschaurbach authored Jan 20, 2024
    Configuration menu
    Copy the full SHA
    7a25869 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Sort RSS Feed by Shelved date 

    This will make sure that users see books as they are shelved, which is what would be expected.

Co-authored-by: Adeodato Simó <[email protected]>
    @mattkatz @dato
    mattkatz and dato authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    7b388ae View commit details
    Browse the repository at this point in the history

  2. /rss shouldn't be optional in the rss route 

    Co-authored-by: Adeodato Simó <[email protected]>
    @mattkatz @dato
    mattkatz and dato authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3754af7 View commit details
    Browse the repository at this point in the history

  3. /rss shouldn't be optional in the rss route 

    Co-authored-by: Adeodato Simó <[email protected]>
    @mattkatz @dato
    mattkatz and dato authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a2e41fa View commit details
    Browse the repository at this point in the history

  4. Correct docstring on rss feed 

    Co-authored-by: Adeodato Simó <[email protected]>
    @mattkatz @dato
    mattkatz and dato authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    975c3ba View commit details
    Browse the repository at this point in the history

  5. Remove extraneous function 

    getting context data no longer seems needed, if it ever was.
    mattkatz committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e3ca543 View commit details
    Browse the repository at this point in the history

  6. use privacy__in to respect shelf privacy settings

    mattkatz committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5b8e083 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Merge branch 'main' into rss-for-shelves

    @mattkatz
    mattkatz authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    63d6486 View commit details
    Browse the repository at this point in the history

  2. add user name to shelf rss feed title 

    Co-authored-by: Adeodato Simó <[email protected]>
    @mattkatz @dato
    mattkatz and dato authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6976cb4 View commit details
    Browse the repository at this point in the history

  3. improve shelf rss description 

    Co-authored-by: Adeodato Simó <[email protected]>
    @mattkatz @dato
    mattkatz and dato authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    cd29b44 View commit details
    Browse the repository at this point in the history

  4. add translation usage

    mattkatz committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1d8bd2b View commit details
    Browse the repository at this point in the history

  5. support same identifiers as book page in rss 

    in book_identifiers.html template we support multiple identifiers in
order.

This commit adopts the same logic and order
    mattkatz committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    09d857e View commit details
    Browse the repository at this point in the history

  6. Missing brackets and correct blocktrans usage

    @dato
    dato authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1e14d63 View commit details
    Browse the repository at this point in the history

  7. Drop default filter in favor of per-metadata item conditionals

    @dato
    dato authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    5340ed3 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. remove pure_name since it only applies to statuses

    mattkatz committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    8dc412c View commit details
    Browse the repository at this point in the history

  2. Don't show a colon if there is no author_text 

    If there is no author for a book, render just the title of the book.
    mattkatz committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    a0d15cc View commit details
    Browse the repository at this point in the history

  3. handle cases where edition has no author

    mattkatz committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    74e2103 View commit details
    Browse the repository at this point in the history

  4. use display_name to avoid name rendering as None

    mattkatz committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    98724df View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. fix edition formatting and add alt link 

    Template blocks can't have logic or other blocks inside them.

This commit fixes the problem with the Edition template by removing the blocktrans block: original titles and descriptions shouldn't be translated, and this also makes the template simpler and avoids the logic-in-blocks problem.

Additionally if an edition is lacking a description, we fall back to the parent_work description, and line breaks have been added where needed.

Also adds a 'rel="alternate"' link to shelf pages to aid feed auto-discovery
    @hughrun
    hughrun committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7c6f001 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Merge branch 'main' into rss-for-shelves

    @hughrun
    hughrun authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9942444 View commit details
    Browse the repository at this point in the history

  2. Merge fix into pr 3013

    @hughrun
    hughrun committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0c0acab View commit details
    Browse the repository at this point in the history