Use shared inboxes for mentions too #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids duplicate submissions to remote instances when mentioning followers (i.e., `POST /user/foo/inbox` followed by `POST /inbox`, which results in two separate `add_status` tasks, and might generate duplicates in the target instance).
mouse-reeve
approved these changes
Feb 3, 2024
| recipients = [u.inbox for u in mentions or [] if not u.local] | ||
| # we always send activities to explicitly mentioned users (using shared inboxes | ||
| # where available to avoid duplicate submissions to a given instance) | ||
| recipients = {u.shared_inbox or u.inbox for u in mentions if not u.local} |
There was a problem hiding this comment.
I didn't realize you could create sets this way, this is great! Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids duplicate submissions to remote instances when mentioning followers (i.e.,
POST /user/foo/inboxfollowed byPOST /inbox, which results in two separateadd_statustasks, and might generate duplicates in the target instance).See, for example, https://lectura.social/user/ArianeDeTroil/comment/58073, where a single comment from my instance generated three copies of the note (because there were two mentions to the same instance). I believe the first commit fixes the issue.