Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pylint to 3.x #3398

Merged
merged 6 commits into from
Jul 27, 2024
Merged

Upgrade pylint to 3.x #3398

merged 6 commits into from
Jul 27, 2024

Conversation

dato
Copy link
Contributor

@dato dato commented Jul 27, 2024

  • 2cdbddc .pylintrc: use symbolic names for message suppressions
  • 1a0fbac pylint: upgrade to 3.2.6
  • 81ee5e9 pylint: remove unused global suppressions

dato added 2 commits July 27, 2024 03:10
This only requires fixing:

    E0606: Possibly using variable 'results' before assignment
    E0606: Possibly using variable 'input_type' before assignment
@dato dato marked this pull request as ready for review July 27, 2024 18:55
@@ -193,8 +193,7 @@ class UsernameField(ActivitypubFieldMixin, models.CharField):

def __init__(self, activitypub_field="preferredUsername", **kwargs):
self.activitypub_field = activitypub_field
# I don't totally know why pylint is mad at this, but it makes it work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a relief to finally be free of this comment :)

@mouse-reeve mouse-reeve merged commit 7f773b3 into main Jul 27, 2024
10 checks passed
@mouse-reeve mouse-reeve deleted the pylint3 branch July 27, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants