-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow an instance to disable federation #3421
Open
mouse-reeve
wants to merge
12
commits into
main
Choose a base branch
from
disable-federation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouse-reeve
force-pushed
the
disable-federation
branch
2 times, most recently
from
August 27, 2024 22:55
04ab58e
to
ebc60ab
Compare
Did I do this right?
mouse-reeve
force-pushed
the
disable-federation
branch
from
August 27, 2024 22:57
ebc60ab
to
595cc24
Compare
Thank you for implementing this. If federation also includes book edits from remote instances, this might be a partial solution for #2841 |
It does prevent book data federation, but it’s not granular at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows an instance to turn off all contact with other ActivityPub services. The instance would still be able to connect to OpenLibrary and Inventaire. If there's existing federated data, there can be some odd behavior (like blocking an existing remote user will "work" but not propagate the block to the other server, and following that user would fail silently), but since I expect this to either be used from the outset or as a stopgap for some unforeseen issue, I didn't bother to clarify those situations in the UI (besides putting up a banner on the user page).
What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Documentation
Tests