Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration branch for #1263 #1277

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Integration branch for #1263 #1277

wants to merge 18 commits into from
+249 −208

Conversation

javiertoledo
Copy link
Member

Description

Integration branch for #1263

Changes

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

hannahbrooks and others added 18 commits December 5, 2022 20:23
@hannahbrooks
fix: 🚧 added initializeGit, installDependencies and interactive flags…
fa72b4c 
… and removed skipInstall and skipGit for new:project command
@BoyuanShao
removed "--default" flag
3116ad1
@hannahbrooks
Merge branch 'main' of https://github.com/hannahbrooks/booster into f…
a5c54db 
…ix/1196_remove-params-from-new-project
@BoyuanShao
WIP: fixed tests and removed default flag
e255329
@BoyuanShao
Merge branch 'fix/1196_remove-params-from-new-project' of https://git…
cd1b2b1 
…hub.com/hannahbrooks/booster into fix/1196_remove-params-from-new-project
@hannahbrooks
test: ✅ update tests for new flags
3636269
@hannahbrooks
test: 🚧 update tests for initializeGit, interactive an installDepende…
d498eca 
…ncies flags
@hannahbrooks
fix: 🚧 changed flags back to skipInstall and skipGit to be optional s…
cd2ba96 
…teps
@hannahbrooks
fix: ✅ updated tests for new requirements
f9c8c54
@hannahbrooks
refactor: ♻️ updated error text
6078e18
@hannahbrooks
refactor: 🎨 removed leftover code from previous commit and changed de…
6029573 
…fault project initializer typing
@hannahbrooks
docs: 📝 updated documentation for new project changes
61fb982
@hannahbrooks
docs: 📝 removed low level detail from getting-started section with pr…
9c42f74 
…ovider section
@hannahbrooks
refactor: 💬 updated interactive flag description
7cf3e64
@hannahbrooks
refactor: ♻️ removed promise resolves from async function
c8d36f4
@hannahbrooks
docs: 📝 simplified tip for provider options in getting started
a59bfed
@hannahbrooks
test: 📝 added description field for minor change
4abc6cc
Merge pull request #1263 from hannahbrooks/fix/1196_remove-params-fro…
c049734 
…m-new-project

[Issue #1196] Change default behaviour of new:project
@what-the-diff
Copy link

what-the-diff bot commented Dec 14, 2022

  • The new:project command now has an interactive mode that allows the user to configure their project.
  • If no provider is specified, it will throw an error instead of using AWS as default (this was a breaking change).
  • Added support for Azure and Kubernetes providers in the CLI's new project wizard (experimental)

@javiertoledo javiertoledo self-assigned this Dec 14, 2022
@ghost
Copy link

ghost commented Dec 14, 2022

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@javiertoledo javiertoledo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiertoledo @hannahbrooks @BoyuanShao