Update CDKTF packages #1486

samueldominguez · 2023-10-27T17:19:46Z

Description

Upgrade CDK TF to latest version

Changes

upgraded cdktf, cdktf-cli, @cdktf/provider-azurerm and @cdktf/provider-time to the latest version
upgraded node to >=18.12.0 < 19.0.0 wherever cdktf* packages are used

Checks

Project Builds
Project passes tests and checks
Updated documentation accordingly

Additional information

If it's an issue moving to node >=18.12.0 <19.0.0 then wen move back to cdktf versions 18.x

what-the-diff · 2023-10-27T17:20:18Z

PR Summary

Updated Tooling Versions
The versions of development tools cdktf and cdktf-cli have been upgraded. The process of ensuring our code is up-to-date and fully supported can lead to improved performance, security, and error resolution.
Upgraded Azure Provider Packages
The versions of Azure-related packages @cdktf/provider-azurerm and @cdktf/provider-time have been updated. This means our infrastructure-as-code will take advantage of the latest features and improvements in Azure services.
Updated Node Version
The version requirement of node has been tweaked for a couple of packages. With this minor update, we ensure the stability and compatibility with the latest version of Node.js.

javiertoledo · 2023-10-30T09:47:23Z

packages/framework-integration-tests/package.json

@@ -78,7 +78,7 @@
    "eslint-plugin-unicorn": "~44.0.2"
  },
  "engines": {
-    "node": ">=18.0.0 <19.0.0"
+    "node": ">=18.12.0 <19.0.0"


Is this a requirement of the new CDK version? Otherwise, I'd leave it as 18.0.0 in order to be less restrictive for end users.

@javiertoledo yes, it seems to be a requirement for the new cdk tf version, see here. If it presents an issue, we can go back to version 0.17 I believe

Gotcha, no objections then!

# Conflicts: # common/config/rush/pnpm-lock.yaml

javiertoledo · 2023-10-30T12:29:08Z

/integration sha=4fc7a593c0f67fb95cded6defbb905c8e2b00c0b

github-actions · 2023-10-30T12:29:31Z

Oops, looks like you forgot to add a changeset.

⚠️ Please run rush change and commit the changeset file.

This command will prompt you for a change description and generate a changeset file. You can read more about changesets here.

Remember that you should use the version bump that is appropriate for the change you are making:

Version bump	Meaning
`patch`	Bug fixes, documentation changes, etc.
`minor`	New features, non-breaking changes
`major`	Breaking changes

If you are unsure about which version bump to use, please ask in the comments and we will help you out.

github-actions · 2023-10-30T12:55:17Z

❌ Oh no! Integration tests have failed

javiertoledo · 2023-10-30T13:03:46Z

It seems that the Azure deployment failed. Maybe there's an API change that needs to be tweaked?

  1) "before all" hook in "***root***":
     Error: the string "npm\n WARN exec The following package was not found and will be installed: [email protected]\n\nError: terraform init failed with exit code 1\n\n\"Deployment of application my-store-4fc7a59 failed. Check cdktf logs. \\nundefined***\"\n    Error: \"Deployment of application my-store-4fc7a59 failed. Check cdktf \n    logs. \\nundefined***\"\n    (You can see the full error logs in ./errors.log)\n" was thrown, throw an Error :)
      at thrown2Error (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:1241:10)
      at Runner.fail (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:443:11)
      at cbHookRun (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:532:14)
      at done (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runnable.js:310:5)
      at /home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runnable.js:377:11
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

samueldominguez · 2023-10-31T16:13:20Z

It seems that the Azure deployment failed. Maybe there's an API change that needs to be tweaked?

  1) "before all" hook in "***root***":
     Error: the string "npm\n WARN exec The following package was not found and will be installed: [email protected]\n\nError: terraform init failed with exit code 1\n\n\"Deployment of application my-store-4fc7a59 failed. Check cdktf logs. \\nundefined***\"\n    Error: \"Deployment of application my-store-4fc7a59 failed. Check cdktf \n    logs. \\nundefined***\"\n    (You can see the full error logs in ./errors.log)\n" was thrown, throw an Error :)
      at thrown2Error (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:1241:10)
      at Runner.fail (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:443:11)
      at cbHookRun (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:532:14)
      at done (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runnable.js:310:5)
      at /home/runner/work/booster/booster/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runnable.js:377:11
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

I suspect it might have to do with rush running the build on 18.18, I've updated it to 18.20, hopefully that fixes it @javiertoledo

samueldominguez · 2023-10-31T16:19:36Z

Actually that broke it! Looking at it again.

samueldominguez · 2023-11-10T12:15:31Z

@javiertoledo I think we can try running integration tests now

samueldominguez added 2 commits October 27, 2023 17:33

upgraded cdktf to 0.19 and helper packages

69ffc7d

upgraded node version to 18.12 whereever cdk packages are used

90c856e

samueldominguez changed the title ~~Upgrade/cdktf 0.19~~ Update CDKTF packages Oct 27, 2023

javiertoledo requested changes Oct 30, 2023

View reviewed changes

javiertoledo approved these changes Oct 30, 2023

View reviewed changes

boostercloud deleted a comment from github-actions bot Oct 30, 2023

Merge remote-tracking branch 'origin/v2.x.x' into upgrade/cdktf-0.19

4fc7a59

# Conflicts: # common/config/rush/pnpm-lock.yaml

rush should use use at least 18.20 to run integration tests

1e4231d

Base automatically changed from v2.x.x to main November 1, 2023 12:15

samueldominguez added 3 commits November 10, 2023 11:50

azure min node version set to 18.12

7329f16

Merge branch 'main' into upgrade/cdktf-0.19

b32d852

added change description for rush

4d3cb2e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CDKTF packages #1486

Update CDKTF packages #1486

samueldominguez commented Oct 27, 2023

what-the-diff bot commented Oct 27, 2023

javiertoledo Oct 30, 2023

samueldominguez Oct 30, 2023

javiertoledo Oct 30, 2023

javiertoledo commented Oct 30, 2023

github-actions bot commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023

javiertoledo commented Oct 30, 2023

samueldominguez commented Oct 31, 2023

samueldominguez commented Oct 31, 2023

samueldominguez commented Nov 10, 2023

Update CDKTF packages #1486

Are you sure you want to change the base?

Update CDKTF packages #1486

Conversation

samueldominguez commented Oct 27, 2023

Description

Changes

Checks

Additional information

what-the-diff bot commented Oct 27, 2023

PR Summary

javiertoledo Oct 30, 2023

Choose a reason for hiding this comment

samueldominguez Oct 30, 2023

Choose a reason for hiding this comment

javiertoledo Oct 30, 2023

Choose a reason for hiding this comment

javiertoledo commented Oct 30, 2023

github-actions bot commented Oct 30, 2023 • edited Loading

github-actions bot commented Oct 30, 2023

javiertoledo commented Oct 30, 2023

samueldominguez commented Oct 31, 2023

samueldominguez commented Oct 31, 2023

samueldominguez commented Nov 10, 2023

github-actions bot commented Oct 30, 2023 •

edited

Loading