variants: add k8s-1.31 variants boilerplate #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the boilerplate for upcoming new k8s-1.31 variants of Bottlerocket. Signed-off-by: Gavin Inglis <[email protected]>
ginglis13
force-pushed
the
k8s-1.31-boilerplate-variants
branch
from
85eb881
to
918d69a
Compare
3 tasks
bcressey
approved these changes
Aug 19, 2024
Comment on lines
+75
to
+76
| Provides: %{_cross_os}settings-plugin(aws-k8s-1.31) | ||
| Provides: %{_cross_os}settings-plugin(aws-k8s-1.31-nvidia) |
There was a problem hiding this comment.
Not a blocker, but this will complicate #4125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Part of #4137
Description of changes:
Add the boilerplate for upcoming new k8s-1.31 variants of Bottlerocket.
Testing done:
Draft until a core kit is released that includes bottlerocket-os/bottlerocket-core-kit#81 . Once that core kit is released and Bottlerocket is updated to use it, will rebase this PR and open for review. For testing these changes, I used a custom built bottlerocket-core-kit.
For testing:
cargo make -e BUILDSYS_VARIANT=vmware-k8s-1.31 -e BUILDSYS_ARCH=x86_64cargo make -e BUILDSYS_VARIANT=aws-k8s-1.31 -e BUILDSYS_ARCH=x86_64cargo make -e BUILDSYS_VARIANT=aws-k8s-1.31-nvidia -e BUILDSYS_ARCH=x86_64cargo make -e BUILDSYS_VARIANT=aws-k8s-1.31 -e BUILDSYS_ARCH=aarch64cargo make -e BUILDSYS_VARIANT=aws-k8s-1.31-nvidia -e BUILDSYS_ARCH=aarch64Launched the
aws-k8s-1.31-aarch64variant and ensured it booted and registered w/ k8s cluster.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.