Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct queue name from sqs job event #139

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Set correct queue name from sqs job event #139

merged 3 commits into from
Nov 23, 2023

Conversation

vmiguellima
Copy link
Contributor

@vmiguellima vmiguellima commented Nov 11, 2023 •
edited
Loading

Why is this needed?

When using laravel queue name suffix feature (queue.connections.sqs.suffix), laravel will allow to dispatch a job using onQueue simply with the queue base name.

This will:

  • always set the correct queue name where the job originated from.
  • allow to work with multiple queues.

Dependencies

  • Bump bref/bref to v2.1.8 to support this changes.

Needs

@vmiguellima vmiguellima mentioned this pull request Nov 11, 2023
Merged
mnapoli
mnapoli reviewed Nov 14, 2023
View reviewed changes
src/Queue/QueueHandler.php Outdated Show resolved Hide resolved
@vmiguellima vmiguellima marked this pull request as ready for review November 14, 2023 20:34
mnapoli
mnapoli approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, that looks awesome

@vmiguellima
Copy link
Contributor Author

@tillkruss @mnapoli Could this be merge? it would unlock me 😅

@mnapoli mnapoli merged commit bc1a5ae into brefphp:master Nov 23, 2023
12 checks passed
@vmiguellima vmiguellima deleted the set-correct-queue-name branch November 23, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnapoli mnapoli mnapoli approved these changes

@georgeboot georgeboot georgeboot approved these changes

@tillkruss tillkruss Awaiting requested review from tillkruss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vmiguellima @tillkruss @mnapoli @georgeboot