Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-195155 Implement saving of FDS item actions in DSM #140636

Closed
wants to merge 5 commits into from

Conversation

markocikos
Copy link

Manual forward, after 🟢 from QA in liferay-frontend#3639 (comment)


References

What is the goal of this PR?

We are implementing persistence for FDS Actions, UI to save and reorder FDS Actions, and doing some minor improvements on the way.

See technical notes inline.

TODO in a separate task:

  • we could have icon instead of icon name in Icon field in the orderable table.
  • we could have localized Type in the orderable table.

What does it look like?

vokoscreenNG-2023-09-11_11-36-36.mp4

@liferay-continuous-integration
Copy link
Collaborator

Closing pull request because all liferay-portal pullrequests sent to Brian Chan must be sent by using ci:forward on a pull request that was sent to someone else.

@markocikos
Copy link
Author

ci:reopen

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: e957a89...4c00346

@brianchandotcom
Copy link
Owner

@markocikos see changes in my origin. Thx.

@markocikos markocikos deleted the LPS-195155 branch June 3, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants