LPS-203834 Apply editor config contributor client extensions to CKEditor #145615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-203834-2 1 Successful Jobs:For more details click here. |
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
@brianchandotcom please publish a new version of workspace once this is merged. Thanks! |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-devtools#10 (Took 1
ci:forwardattempt in 1 minute)Console
@markocikos
@liferay-devtools
Original pull request comment:
References
What is the goal of this PR?
As a part of the pash, we are adding a workspace sample. New client extension type requires update of gradle-plugin-workspace, that's the reason I am opening PR on this fork. @drewbrokke please take a look if everything is configured correctly. The logic of implementation was already reviewed, so feel free to forward this to Brian if everything is ok.