feat: show pay & book label to the meeting confirmation button when payment is enabled.
#12960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
Medium priority
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
PeerRich
reviewed
Jan 1, 2024
joeauyeung
previously approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Thanks for your contribution @SomayChauhan!
Tested both with a new booking and "Reschedule" still renders when rescheduling a paid booking.
github-actions
bot
added
billing
joeauyeung
approved these changes
Jan 18, 2024
|
As a follow up, I noticed that when the payment type is charge no-show fee we don't communicate that. It would be cool if we displayed that on the availability page and changed the confirm button text to reflect that. |
zomars
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12271
Screencast.from.29-12-23.12.30.27.PM.IST.webm