Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSETOOLS2-2302: Allow to link utils package during Main build of Camel tooling projects #1664

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pospisilf
Copy link
Contributor

Pull Request informations

Rebase & Merge default requirements

  1. Green build for main branch
  2. Wait 24 hours after PR creation
  3. Green job for PR
  4. Approved PR

PR labels default process

  • READY_FOR_REVIEW → REVIEW_DONE → READY_FOR_MERGE

Tests

  • Are there Unit tests?
  • Are there Integration tests?
  • Do we need a new UI test?

PR workflow progress

  1. Tagged with relevant PR labels
  2. Green job for PR
  3. PR was created more than 24 hours ago or All committers approved it
  4. Green main branch build

@pospisilf pospisilf changed the title Allow to link utils package during Main build of Camel tooling projects FUSETOOLS2-2302: Allow to link utils package during Main build of Camel tooling projects Feb 21, 2024
@pospisilf pospisilf force-pushed the FUSETOOLS2-2302 branch 5 times, most recently from a6e5a9a to 511e128 Compare February 22, 2024 16:56
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pospisilf pospisilf marked this pull request as ready for review February 26, 2024 09:47
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to understand what is happening.

In case, we need to provide modifications to vscode-uitests-tooling then we can use it without modification. For that it checks if there is a branch with the same name than the current build of camel-lsp-client-vscode?

@pospisilf
Copy link
Contributor Author

I'm not sure to understand what is happening.

In case, we need to provide modifications to vscode-uitests-tooling then we can use it without modification. For that it checks if there is a branch with the same name than the current build of camel-lsp-client-vscode?

We want to move as much as possible to utils package instead of having functions in individual components as these functions are very often used in more than one component. If you want to make changes in utils package as well, you need branch with same name as branch in camel-lsp-client-vscode. If there's no branch with same nebo or fork of utils repo at all, flow will be acting like until now. If there's branch with same name, build of this branch will be used for testing PR flow. In a summary, if I add function A to utils branch and call it inside some PR here, on camel-lsp-client-vscode, it will pass. It's necessary to publish utils package first. If not, after merge on camel-lsp-client-vscode will main pipeline fail.

@apupier
Copy link
Member

apupier commented Mar 8, 2024

It's necessary to publish utils package first. If not, after merge on camel-lsp-client-vscode will main pipeline fail.

that's a key point. Thanks for the clarification

Copy link
Member

@djelinek djelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, wait for follow up tasks before merge of this one

@djelinek djelinek marked this pull request as draft March 13, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants