Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browserify injector #24

Merged
merged 4 commits into from
Dec 13, 2016

Conversation

SevereOverfl0w
Copy link
Contributor

#23 should satisfy this.

@jescalan
Copy link
Contributor

Lovely. Good work, thanks @SevereOverfl0w!

@jescalan
Copy link
Contributor

Two small comments before merge:

  1. Could you squash be065e8 and 1ce2820 together?
  2. Could you document this feature in the readme?

SevereOverfl0w added 2 commits September 21, 2015 18:25
This function auto-injects the file built by the browserify extension.
@SevereOverfl0w
Copy link
Contributor Author

Is there any way for me to see what way I've reduced coverage? I have an idea, but I'd like to know specifically.

@kylemac
Copy link
Contributor

kylemac commented Sep 21, 2015

@SevereOverfl0w one way is to run the coverage script locally, npm run coverage

https://github.com/carrot/roots-browserify/blob/master/package.json#L51

@SevereOverfl0w
Copy link
Contributor Author

Ah, didn't even think to look for that. Looks like the issue is that I
don't at any point test for unprefixed calls.. hmm... may have an idea for
that.

On 21 September 2015 at 18:45, Kyle MacDonald [email protected]
wrote:

@SevereOverfl0w https://github.com/SevereOverfl0w one way is to run the
coverage script locally, npm run coverage

https://github.com/carrot/roots-browserify/blob/master/package.json#L51


Reply to this email directly or view it on GitHub
#24 (comment)
.

@SevereOverfl0w
Copy link
Contributor Author

Okay, resolved. Thanks for that @kylemac.

Copy link
Contributor

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey wow somehow let this slip under the radar, sorry about that!

@jescalan jescalan merged commit ec28e9d into carrot:master Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants