-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQS: add support for passing MessageAttributes #2059
Conversation
6d14ee3
to
9e69540
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR! this will need sufficient tests and possibly some documentation as it seems to be a somewhat new feature for SQS
I wasn't sure what's expected in terms of tests and docs - also couldn't build docs - got this error:
|
Found how to run tests, should be okay now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aviramha can you share some logs showing it works on an actual environment though?
Just to be on the safe-side so we can also see it actually works (apart of the code review which makes sense to me + the unit test which looks fine).
Thanks!
|
Hi!
I looked for a contributing guide and couldn't find one, so apologies if I missed any requirement/need.
SQS supports MessageAttributes, and with this PR, users using celery can easily add message attributes like this:
Notes:
This is probably useful for many reasons, but in our case it's blocking use of feature we provide over it - metalbear-co/mirrord#2066