Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): mark GitHub releases as latest from prerelease #1277

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

p5
Copy link
Contributor

@p5 p5 commented Aug 18, 2024

Closes #1276
Closes #639

By using pre-releases, new updates are not discoverable by users and tooling. GitHub does not promote these as much, and tools like Renovate and Dependabot will exclude all pre-release packages by default.

This PR changes the Goreleaser configuration to no longer create pre-release packages, and instead create proper releases which will be available at the https://github.com/chainguard-dev/apko/releases/latest URL.

While I do not know anything about goreleaser, there is a prerelease: true line which does look to be the cause for this.

This appears to have been set when GoReleaser was first introduced to this repository over two years ago, and I assume may have been something that has been overlooked.

@p5
Copy link
Contributor Author

p5 commented Aug 18, 2024

Do I need to setup a PGP key in order to commit to this repository?
I am already signing commits using my SSH key, which I would hope is enough for flipping a boolean.

@p5 p5 changed the title fix(ci): mark releases as latest, from the current prerelease fix(ci): mark GitHub releases as latest from prerelease Aug 18, 2024
@xnox
Copy link
Contributor

xnox commented Sep 11, 2024

a new release got cut and marked as latest; and there is no need to default to marking things as latest, as we can always edit a release after all the artifacts are built.

@xnox xnox closed this Sep 11, 2024
@xnox xnox reopened this Sep 30, 2024
@xnox
Copy link
Contributor

xnox commented Sep 30, 2024

and we keep forgetting to mark releases as released.

@xnox xnox enabled auto-merge (squash) September 30, 2024 09:57
@xnox xnox merged commit 782dfcf into chainguard-dev:main Sep 30, 2024
22 of 23 checks passed
@p5
Copy link
Contributor Author

p5 commented Sep 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark GitHub releases as latest Question: why do we create prereleases for apko?
2 participants