Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test.enabled and test.exclude-reason fields #1521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add test.enabled and test.exclude-reason fields #1521

wants to merge 1 commit into from

Conversation

Dentrax
Copy link
Contributor

@Dentrax Dentrax commented Sep 27, 2024 •
edited
Loading

Melange Pull Request Template

Adds ExcludeReason field for tracking why package tests are disabled. Used pointer bool to run the tests even enabled fields is not set.

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

@Dentrax Dentrax force-pushed the test-disable-reason branch 2 times, most recently from 4d0a236 to dbd57a7 Compare September 27, 2024 22:50
@Dentrax Dentrax mentioned this pull request Sep 28, 2024
Draft
@Dentrax Dentrax marked this pull request as ready for review September 28, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dentrax