Do not continue doing things after Ctrl+C #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
force-pushed
the
mp/fix-ctrl-c-on-cleanse
branch
3 times, most recently
from
e31b682
to
3967fa9
Compare
marcparadise
commented
Apr 3, 2017
| @@ -322,7 +322,7 @@ def scary_cleanse_warning(*args) | |||
| sleep 60 | |||
| rescue Interrupt | |||
| log "" | |||
| exit 0 | |||
| Kernel.exit 1 | |||
There was a problem hiding this comment.
THese seemed a safe exit code change to make, because this is handling for when the operator explicitly does not pass the --yes argument that will bypass the wait period
Interrupted CLIs typically exit non-zero.
ksubrama
approved these changes
May 4, 2017
PrajaktaPurohit
force-pushed
the
mp/fix-ctrl-c-on-cleanse
branch
from
3967fa9
to
80cfc6a
Compare
|
@marcparadise Is this something we want to get merged in still? Seems worth shipping. |
|
Yeah, this looks like something that we still want. |
Call Kernel.exit! 1 to force an immediate error-exit if the operator uses Ctrl+C to prevent performing post-hook steps. Signed-off-by: Marc A. Paradise <[email protected]>
marcparadise
force-pushed
the
mp/fix-ctrl-c-on-cleanse
branch
from
80cfc6a
to
2c7b3b7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call Kernel.exit! 1 to force an immediate error-exit
if the operator uses Ctrl+C to prevent performing post-hook steps.
Signed-off-by: Marc A. Paradise [email protected]