docs: fix links #42
Draft
docs: fix links #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Ibrahim <[email protected]>
kkourt
reviewed
Mar 6, 2023
| @@ -8,8 +8,7 @@ as being storage efficient are the main goals. | |||
|
|
|||
| It uses [qemu](https://www.qemu.org/) and [libguestfs tools](https://libguestfs.org/). | |||
|
|
|||
| Configurations for specific images used in the Cilium project can be found in: | |||
| https://github.com/cilium/little-vm-helper-images. | |||
| Configurations for specific images used in the Cilium project can be found in [little-vm-helper-image](https://github.com/cilium/little-vm-helper-images). | |||
There was a problem hiding this comment.
Suggested change
| Configurations for specific images used in the Cilium project can be found in [little-vm-helper-image](https://github.com/cilium/little-vm-helper-images). | |
| Configurations for specific images used in the Cilium project can be found in [little-vm-helper-images](https://github.com/cilium/little-vm-helper-images). |
| @@ -149,17 +148,16 @@ go run cmd/lvh --image _data/images/base.qcow2 --qemu-disable-kvm | |||
| ### Why not use packer to build images? | |||
|
|
|||
| Existing packer builders | |||
| (e.g,.https://github.com/cilium/packer-ci-build/blob/710ad61e7d5b0b6872770729a30bcdade2ee1acb/cilium-ubuntu.json#L19, | |||
| https://www.packer.io/plugins/builders/qemu) are meant to manage VMs with | |||
| (e.g, [packer-ci-build/cilium-ubuntu.json](https://github.com/cilium/packer-ci-build/blob/710ad61e7d5b0b6872770729a30bcdade2ee1acb/cilium-ubuntu.json#L19), | |||
There was a problem hiding this comment.
Suggested change
| (e.g, [packer-ci-build/cilium-ubuntu.json](https://github.com/cilium/packer-ci-build/blob/710ad61e7d5b0b6872770729a30bcdade2ee1acb/cilium-ubuntu.json#L19), | |
| (e.g., [packer-ci-build/cilium-ubuntu.json](https://github.com/cilium/packer-ci-build/blob/710ad61e7d5b0b6872770729a30bcdade2ee1acb/cilium-ubuntu.json#L19), |
| (e.g,.https://github.com/cilium/packer-ci-build/blob/710ad61e7d5b0b6872770729a30bcdade2ee1acb/cilium-ubuntu.json#L19, | ||
| https://www.packer.io/plugins/builders/qemu) are meant to manage VMs with | ||
| (e.g, [packer-ci-build/cilium-ubuntu.json](https://github.com/cilium/packer-ci-build/blob/710ad61e7d5b0b6872770729a30bcdade2ee1acb/cilium-ubuntu.json#L19), | ||
| [qemu](https://www.packer.io/plugins/builders/qemu)) are meant to manage VMs with |
There was a problem hiding this comment.
Suggested change
| [qemu](https://www.packer.io/plugins/builders/qemu)) are meant to manage VMs with | |
| [packet.io qemu plugin](https://www.packer.io/plugins/builders/qemu)) are meant to manage VMs with |
| @@ -179,11 +177,10 @@ and storage. | |||
| - [x] kernels: add suport for buidling kernels | |||
| - [x] runner: qemu runner wrapper | |||
| - [x] images bootable VMs: running qemu with --kernel is convinient for development. If we want to store images externally (e.g., AWS), it might make sense to support bootable VMs. | |||
| - [ ] improve boot time: minimal init, use qemu microvm (https://qemu.readthedocs.io/en/latest/system/i386/microvm.html, https://mergeboard.com/blog/2-qemu-microvm-docker/) | |||
| - [ ] improve boot time: minimal init, use qemu microvm ([microvm](https://qemu.readthedocs.io/en/latest/system/i386/microvm.html), [QEMU MicroVMs](https://mergeboard.com/blog/2-qemu-microvm-docker/)) | |||
There was a problem hiding this comment.
Suggested change
| - [ ] improve boot time: minimal init, use qemu microvm ([microvm](https://qemu.readthedocs.io/en/latest/system/i386/microvm.html), [QEMU MicroVMs](https://mergeboard.com/blog/2-qemu-microvm-docker/)) | |
| - [ ] improve boot time: minimal init, use qemu microvm ([microvm virtual platform](https://qemu.readthedocs.io/en/latest/system/i386/microvm.html), [Execute Docker Containers as QEMU MicroVMs](https://mergeboard.com/blog/2-qemu-microvm-docker/)) |
| - [ ] images: on a failed run, save everything in a image-failed-$(date) directory | ||
| - [ ] use `guestfish --listen` (see | ||
| https://github.com/libbpf/ci/blob/cbb3b92facbad705bbb619b496d0debb4b3d806f/prepare-rootfs/run.sh#L345) | ||
| - [ ] use `guestfish --listen` (see [prepare-rootfs/run.sh](https://github.com/libbpf/ci/blob/cbb3b92facbad705bbb619b496d0debb4b3d806f/prepare-rootfs/run.sh#L345)) |
There was a problem hiding this comment.
Suggested change
| - [ ] use `guestfish --listen` (see [prepare-rootfs/run.sh](https://github.com/libbpf/ci/blob/cbb3b92facbad705bbb619b496d0debb4b3d806f/prepare-rootfs/run.sh#L345)) | |
| - [ ] use `guestfish --listen` (see [libbpf's prepare-rootfs/run.sh](https://github.com/libbpf/ci/blob/cbb3b92facbad705bbb619b496d0debb4b3d806f/prepare-rootfs/run.sh#L345)) |
|
Moving the PR to draft due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.