Fix skb tracing on veth #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilium#339 changed how pwru collects skb_addr, now it holds the value of skb->head instead of &skb. This patch renames value name `skb_addr` to `skb_head`, as well as map name `skb_addresses` to `skb_heads`. Signed-off-by: gray <[email protected]>
After cilium#339, skb_addresses (now skb_heads) map uses skb->head as key rather than &skb. Kprobe prog on veth_convert_skb_to_xdp_buff should be adjusted to that change. Signed-off-by: gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #339, skb_addresses map stores skb->head as key, but kprobe prog on veth_convert_skb_to_xdp_buff still lookup map by &skb. This PR makes things right.
Fixes: #391