Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark missing for absent pypi package download url #470

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

qtomlinson
Copy link
Collaborator

@qtomlinson qtomlinson commented Mar 11, 2022

  1. when the pypi package download url is absent in the registry data, mark missing (See No files showing on components details page website#964 (comment))
  2. some versions of pypi packages can be in zip format. Allowed downloading zip files by checking download url for zip format

Test cases:

  1. missing package download url in registry data: pypi/pypi/-/dnspython/1.0.0
  2. zip file: pypi/pypi/-/dnspython/1.11.0
  3. tar.gz file: pypi/pypi/-/dnspython/2.2.1

Task: clearlydefined/website#964

1. when the pypi package download url is absent in the registry data, mark missing
2. some versions of pypi packages can be in zip format.  Allowed downloading zip files by checking download url for zip format

 Test cases:
 1. missing package download url in registry data: pypi/pypi/-/dnspython/1.0.0
 2. zip file: pypi/pypi/-/dnspython/1.11.0
 3. tar.gz file: pypi/pypi/-/dnspython/2.2.1
@qtomlinson
Copy link
Collaborator Author

@jeffwilcox ready for review :)

@jeffwilcox jeffwilcox merged commit 3f72d6d into clearlydefined:master Mar 14, 2022
@qtomlinson qtomlinson deleted the qt/fix_pypi_missing branch March 15, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants