Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to LicensePicker component #1013

Open
bduranc opened this issue Jan 11, 2023 · 1 comment
Open

Improvement to LicensePicker component #1013

bduranc opened this issue Jan 11, 2023 · 1 comment

Comments

@bduranc
Copy link

bduranc commented Jan 11, 2023

Originally mentioned in #955

The current implementation of LicensePicker component has some major functionality and usability issues...

  1. only one radio button can be selected at any time:

211380438-a703de4f-d8be-4890-856d-6bae92c6f2ed

  1. if you repetitively hit "add group" and create multiple empty groups, in some cases I found you cannot delete them after:

211381162-139c69ac-c228-4103-a243-d7babe4b2746

  1. in more complex expressions with multiple groups, the top radios change the middle most logical operator which may be confusing for some:

image

If we look at the original implementation, it functioned much the same but had some UI features that made it more user-friendly IMO:

51443465-0b35da80-1c9e-11e9-8086-02d802b71308

Specifically:

  • borders around each group tells you what controls go with which group (even the buttons at very top are clear as to their effect)
  • buttons instead of radio boxes (even if these are radios "styled" as buttons, they still function independently)
  • not sure if the behavior described in point 2 also affected the original implementation, but it does occur in this one
  • there appeared to be some syntax checking for the expression, not sure if this is happening in the current implementation
@bduranc
Copy link
Author

bduranc commented Oct 13, 2023

Can confirm as of 10/13/2023 this is still a present observation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant