Not able to edit file-level license

[capfei]

The edit button does nothing when trying to edit the license info for a file. Also, clicking on the license field does nothing.

[bduranc]

This appears to be supported now, but the quality of this functionality is still very poor:

1. the resulting dialog's radio buttons is confusing - only one radio in the whole form can be selected at any time:

2. If you repetitively hit "add group" and create multiple empty groups, you cannot delete them after.

[capfei]

Can confirm that I am able to do file-level edits (haven't submitted a PR, though) and experiencing the same issue with the radio buttons.

[qtomlinson]

Previous commit reused LicensePicker for license editing. It seems that LicensePicker needs some work as well.

[qtomlinson]

@capfei @bduranc The improvement needed in LicensePicker is more general and not limited to "file-level license" editing. Editing license in the "Described and Licensed" of the definition page shows the same dialogue and needs the same improvement. The original use case of "Not able to edit file-level license" is now supported. The improvement for LicensePicker is better documented in a separate issue, so that all the test cases (file-level and declared license) can be addressed.

[bduranc]

Alright, I will open new issue to discuss the usability of this dialog box.

It is worth mentioning that in the old UI, this function did work much better because none of these issues existed.

[bduranc]

I confirmed I was able to submit this curation PR: clearlydefined/curated-data#23164

I created issue #1013 addresses the larger problemswith the LicensePicker component itself. But for the original scope of this issue, it looks like the problem is fixed.

@capfei do we want to close this?