Skip to content

Commit

Permalink
ApertiumLintBear: Pin lxml to support Python 3.4
Browse files Browse the repository at this point in the history
lxml 4.4.0 dropped support for Python 3.4.
Hence, the version is capped below 4.4.0.

Closes #2940
  • Loading branch information
abhishalya authored and jayvdb committed Aug 5, 2019
1 parent 3462f3c commit ca685b2
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion bear-metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ bear_metadata:
apertium-lint:
version: ~=0.29
lxml:
version: '>=1.0'
version: '>=1.0,<4.4.0'
languages:
- Apertium
tags:
Expand Down
2 changes: 1 addition & 1 deletion bear-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ html-linter~=0.4.0
isort~=4.2
language-check~=1.0
libclang-py3~=3.4.0
lxml>=1.0
lxml>=1.0,<4.4.0
memento-client~=0.6.1
munkres~=1.1.2
mypy==0.590
Expand Down
2 changes: 1 addition & 1 deletion bear-requirements.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ pip_requirements:
libclang-py3:
version: ~=3.4.0
lxml:
version: '>=1.0'
version: '>=1.0,<4.4.0'
memento-client:
version: ~=0.6.1
munkres:
Expand Down
2 changes: 1 addition & 1 deletion bears/apertium/ApertiumLintBear.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class ApertiumLintBear:
"""
LANGUAGES = {'Apertium'}
REQUIREMENTS = {PipRequirement('apertium-lint', '0.29'),
PipRequirement('lxml', '>=1.0')}
PipRequirement('lxml', '>=1.0,<4.4.0')}
AUTHORS = {'The coala developers'}
AUTHORS_EMAILS = {'[email protected]'}
LICENSE = 'AGPL-3.0'
Expand Down

0 comments on commit ca685b2

Please sign in to comment.