Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: license lint: make license header linter accept CockroachDB Software License #131873

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jlinder
Copy link
Collaborator

@jlinder jlinder commented Oct 4, 2024

Backport 1/1 commits from #131665.

/cc @cockroachdb/release


Change the license header linter so it accepts the existing options or the CockroachDB Software License (CSL) for these cases:

  • CCL files
  • BSL files

This change allows the piecemeal changing of license headers to the CockroachDB Software License over multiple PRs.

Part of RE-658

Release note: none


Release justification: Need to change the cockroach license to the CockroachDB Software License (CSL).

Copy link

blathers-crl bot commented Oct 4, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 4, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jlinder
Copy link
Collaborator Author

jlinder commented Oct 4, 2024

A few notes:

  • Raft had not been imported to the repo yet in this version, so linting the raft files is not necessary and is not included in this backport.
  • This incorporates the fix from license-linter: Fix typo #131709.

…License

Change the license header linter so it accepts the existing options or
the CockroachDB Software License (CSL) for these cases:

- CCL files
- BSL files

This change allows the piecemeal changing of license headers to the
CockroachDB Software License over multiple PRs.

Part of RE-658

Release note: none
@jlinder jlinder requested review from rail and removed request for rickystewart October 4, 2024 03:39
@jlinder jlinder merged commit f035305 into cockroachdb:release-23.2 Oct 4, 2024
5 of 6 checks passed
@jlinder jlinder deleted the backport23.2-131665 branch October 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants