Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest-release-details include to actually show the latest release, use for v24.1 #18832

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mdlinville
Copy link
Contributor

When developing the tooling for innovation releases, I created an include to use on install and upgrade pages to always show what the latest version is, no matter what version of the page you are viewing. This was to help the reader get to the latest version of CockroachDB and of the page, if possible. However, I used the include only in the v24.2 version of the files and this did not cause the logic to fire, so I didn't notice that it was not actually working as intended.

This PR fixes that and updates the v24.1 install and upgrade pages to use the include, so that the v24.1 pages now show that v24.2 is currently the latest.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit daf0618
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66c38c225e254600086b0305

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit daf0618
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66c38c225e254600086b0308

Copy link

netlify bot commented Aug 16, 2024

Netlify Preview

Name Link
🔨 Latest commit daf0618
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66c38c228f8923000850a370
😎 Deploy Preview https://deploy-preview-18832--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdlinville mdlinville changed the title Fixd latest-release-details include to actually show the latest release, use for v24.1 Fix latest-release-details include to actually show the latest release, use for v24.1 Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant