add linux support #175
Open
add linux support #175
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rail
requested changes
Dec 14, 2023
| @@ -5,6 +5,10 @@ class CockroachSql < Formula | |||
| desc "Distributed SQL database shell" | |||
| homepage "https://www.cockroachlabs.com" | |||
| version "23.1.11" | |||
| on_linux do | |||
| url "https://binaries.cockroachdb.com/cockroach-sql-v23.1.11.linux-amd64.tgz" | |||
| sha256 "8a42076aa8d4448820eb47d9816d08f110d830b263e7edfab1e57f354e6817bb" | |||
There was a problem hiding this comment.
This file is generated, see the top comment.
In order to add Linux, you need to edit https://github.com/cockroachdb/homebrew-tap/blob/master/release/main.go to include the new platform.
Also, you proably want to separate amd64 and arm64 architectures. And the file needs a bit of refactoring to become more readable with so many platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that these formulae only support MacOS. I use Linux. I tested this out on ubuntu-22.04 and it works like a charm. I tried doing something similar with
cockroachand unfortunately it wasn't so easy because of the extra stuff that cockroach does for GEOS support. It'd be great if there was Linux support for all of the formulae in this repo. I'm happy to open an issue to track that need if you'd like.Thanks!
Mark