chore: update dind examples to use onCreateCommand #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
reviewed
Sep 19, 2024
johnstcn
changed the title
mafredri
approved these changes
Sep 19, 2024
| # which will handle most of the steps of setting up Docker. | ||
| # We can't put this in the entrypoint as it gets overridden, so | ||
| # we call it in the on-create script. |
There was a problem hiding this comment.
Do we not support setting entrypoint in the Dockerfile at all? Maybe we should in the future.
There was a problem hiding this comment.
My observation is that whatever entrypoint you set gets overridden by ENVBUILDER_INIT_COMMAND / ENVBUILDER_INIT_SCRIPT. But agreed, we should fall back to the entrypoint in the Dockerfile.
There was a problem hiding this comment.
For a Coder workspace we need to have coder_agent.*.init_script as the entry point so another option to handle the ENTRYPOINT is to run it as part of coder_agent startup_script. This will work for at least the case when envbuilder is used with Coder.
There was a problem hiding this comment.
Filed #351 to follow up on this.
mafredri
pushed a commit
that referenced
this pull request
Oct 2, 2024
(cherry picked from commit 7c8e6a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Docker examples override
ENVBUILDER_INIT_SCRIPT, which is annoying if you're trying to use them with Coder. Update the examples indockerto useonCreateCommandinstead.To test them out locally: