fix: allow caching run layers with no filesystem changes #355
+74
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Sep 25, 2024
| NoPush: !opts.PushImage || len(destinations) == 0, | ||
| CacheRunLayers: true, | ||
| CacheCopyLayers: true, | ||
| ForceBuildMetadata: opts.PushImage, // Force layers with no changes to be cached, required for cache probing. |
There was a problem hiding this comment.
Is there any downside to always enabling this option regardless of PushImage?
There was a problem hiding this comment.
I'm not sure. It'll be an additional cache layer to download during builds vs executing the command and ending up with the same result. Mainly added it to be cautious.
Imagine the following scenario:
RUN if [[ $(date +%s) -gt 1734998400 ]]; then touch "/'member-christmas?"; fiWith force build metadata, we would still use the cache here and not produce a new image (assuming cache exists from before).
There was a problem hiding this comment.
Fair enough, let's leave as-is for now 👍
johnstcn
approved these changes
Sep 25, 2024
johnstcn
pushed a commit
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 67cb94c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this issue turned out to be quite easy as Kaniko had an option for it already. We now enable caching of empty layers by enabling the
ForceBuildMetadataoption whenever push image is set.Fixes #326