Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use openfile to explicitly set magic image perms #370

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: use openfile to explicitly set magic image perms #370

merged 1 commit into from
Sep 27, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Sep 27, 2024 •
edited
Loading

This should fix an issue in our provider tests where build was producing an -rw-r--r-- and cache probing an -rw-rw-r-- image file, resulting in a cache miss.

johnstcn
johnstcn approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 TF_ACC=1 go test -count=1 ./internal/provider/ 
ok      github.com/coder/terraform-provider-envbuilder/internal/provider        37.437s

@mafredri mafredri merged commit 0a11dad into main Sep 27, 2024
4 checks passed
@mafredri mafredri deleted the mafredri/fix-create-magic-image-perms branch September 27, 2024 19:47
johnstcn pushed a commit that referenced this pull request Sep 27, 2024
@mafredri @johnstcn
fix: use openfile to explicitly set magic image perms (#370)
03def87 
(cherry picked from commit 0a11dad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @johnstcn