Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quote output of init command and args to prevent multiline log #378

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: quote output of init command and args to prevent multiline log #378

merged 1 commit into from
Oct 1, 2024

Conversation

mafredri
Copy link
Member

Before:

=== Running the init command /usr/bin/echo [abra
cadabra
] as the "coder" user...
abra
cadabra

After:

=== Running init command as user "coder": ["/usr/bin/echo" "abra\ncadabra\n"]
abra
cadabra

Refs coder/coder#14882

mtojek
mtojek approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you can't go without my approval :)

@mafredri mafredri merged commit a9cb987 into main Oct 1, 2024
4 checks passed
@mafredri mafredri deleted the mafredri/prettier-init-log branch October 1, 2024 08:12
mafredri added a commit that referenced this pull request Oct 2, 2024
@mafredri
fix: quote output of init command and args to prevent multiline log (#…
0ec371f 
…378)

(cherry picked from commit a9cb987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@johnstcn johnstcn johnstcn approved these changes

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mafredri @dannykopping @johnstcn @mtojek