Skip to content

Commit

Permalink
github issue
Browse files Browse the repository at this point in the history
  • Loading branch information
dlesbre committed Jul 12, 2024
1 parent 039c2de commit 3861e5d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ type (_, 'b) snd = Snd of 'b [@@unboxed]
It should not incur any extra performance cost as it is unboxed, but can appear
when manipulating non-generic maps.

For more details about this issue, see [the OCaml discourse discussion](https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783).
For more details about this issue, see [the OCaml discourse discussion](https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783) or [the github issue](https://github.com/ocaml/ocaml/issues/13292).

## Comparison to other OCaml libraries

Expand Down
3 changes: 2 additions & 1 deletion src/index.mld
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,8 @@ type (_, 'b) snd = Snd of 'b [@@unboxed]
It should not incur any extra performance cost as it is unboxed, but can appear
when manipulating non-generic maps.

For more details about this issue, see {{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783}the OCaml discourse discussion}.
For more details about this issue, see {{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783}the OCaml discourse discussion}
or {{: https://github.com/ocaml/ocaml/issues/13292}the github issue}.

{1 Comparison to other OCaml libraries}

Expand Down
3 changes: 2 additions & 1 deletion src/key_value.mli
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ module WrappedHomogeneousValue : HETEROGENEOUS_VALUE with type ('a,'map) t = ('a
(** Same as {!HomogeneousValue}, but uses a wrapper (unboxed) type instead of direct
equality. This avoids a problem in the typechecker with overly eager simplification of aliases.
More info on
{{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783} the OCaml discourse post}. *)
{{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783} the OCaml discourse post}
and {{: https://github.com/ocaml/ocaml/issues/13292}the github issue}. *)

module HashedValue : HASHED_VALUE with type 'a t = 'a
(** Generic implementation of {!HASHED_VALUE}.
Expand Down
3 changes: 2 additions & 1 deletion src/signatures.ml
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,8 @@ end
Since the type is unboxed, it doesn't introduce any performance overhead.
This is due to a bug in the typechecker, more info on
{{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783} the OCaml discourse post}. *)
{{: https://discuss.ocaml.org/t/weird-behaviors-with-first-order-polymorphism/13783} the OCaml discourse post}
and {{: https://github.com/ocaml/ocaml/issues/13292}the github issue}. *)
type (_, 'b) snd = Snd of 'b [@@unboxed]


Expand Down

0 comments on commit 3861e5d

Please sign in to comment.