Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker configuration #102

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add Docker configuration #102

wants to merge 8 commits into from

Conversation

rodfersou
Copy link
Member

No description provided.

@rodfersou rodfersou self-assigned this Jul 7, 2020
@rodfersou rodfersou marked this pull request as ready for review July 8, 2020 04:03
@rodfersou rodfersou requested a review from ericof July 8, 2020 04:08
@petschki petschki removed their request for review July 8, 2020 16:04
@petschki
Copy link
Member

petschki commented Jul 8, 2020

sry ... I'm not the right reviewer for this changes

@rodfersou
Copy link
Member Author

rodfersou commented Jul 9, 2020

@petschki thanks

if you want to try, just install docker and docker compose:
https://docs.docker.com/get-docker/
https://docs.docker.com/compose/install/ (depending on your platform, the previous step also install this)

and run the commands:

make docker-build
make docker-start

In a new clone of this addon.

The idea here is to have same environment for development, CI, tests, staging and production, making it easier to get the Plone running.

Plone Docker image comes with almost everything needed to run Plone, run dependencies and cache.

Regards

@rodfersou
Copy link
Member Author

After merge this branch will try to prepare a new branch to test Travis with Docker

@coveralls
Copy link

coveralls commented Jul 16, 2020

Coverage Status

Coverage decreased (-0.001%) to 44.76% when pulling 2cfbb1a on docker into d0c72e3 on master.

@rodfersou rodfersou requested a review from djay July 20, 2020 23:18
Copy link
Member

@avoinea avoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrTango
Copy link
Contributor

MrTango commented May 29, 2021

@rodfersou could you please have a look on my last commit to resolve the conflicts in the Makefile. If thats all fine, let's merge this.

@MrTango
Copy link
Contributor

MrTango commented May 29, 2021

Not sure if we still need: VIRTUALENV_NOT_INSTALLED, i changed the way the venv is created to the Python3 way and also create in venv not in ".".

@MrTango
Copy link
Contributor

MrTango commented May 29, 2021

there seem to be version issues with plone.recipe.codeanalysis, i'm not a big fan of this package amnyway, usually i use a tox setup with some flake8 directly. But we don't have this setup here right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants