feat: added RAC components + autocomplete attr to all applicable fields #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix this issue:
#117
Accessibility tools point out as errors the fact that form fields do not have an autocomplete attribute.
This PR aims to allow editors to set autocomplete values according to the form field role.
Since semantic-ui does not support autocomplete as a prop, I added the react-aria-components library as a dependency from this addon. However, since this library is going to be applied to volto as a whole, someday probably it won't be necessary to have it installed in this addon.
I used this library as it is the one that will be implemented, but of course I'm open to discuss and making changes in case it is not the best option.