Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5564 Add Date & Time in FeedBack Content #5577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #5564 Add Date & Time in FeedBack Content #5577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/src/main/java/fr/free/nrw/commons/feedback/FeedbackContentCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import fr.free.nrw.commons.feedback.model.Feedback;
import fr.free.nrw.commons.utils.LangCodeUtils;
import java.util.Locale;
import java.time.LocalDateTime;
import java.time.format.DateTimeFormatter;

/**
* Creates a wikimedia recognizable format
Expand All @@ -28,6 +30,10 @@ public FeedbackContentCreator(Context context, Feedback feedback) {
public void init() {
// Localization is not needed here, because this ends up on a page where developers read the feedback, so English is the most convenient.

LocalDateTime currentDateTime = LocalDateTime.now();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call requires API level 26 (current min is 21): java.time.LocalDateTime#now
Call requires API level 26 (current min is 21): java.time.format.DateTimeFormatter#ofPattern
Call requires API level 26 (current min is 21): java.time.LocalDateTime#format

This will throw error on API 26. You will need to use desugaring inorder to get this support towards to API 21.

Ref : https://stackoverflow.com/questions/56695997/how-to-fix-call-requires-api-level-26-current-min-is-25-error-in-android

This will increase unnecessary refactoring this can be done with this 2 line of code.

        final SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss", Locale.ENGLISH);
        String formattedDateTime = formatter.format(new Date());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gupta-Suruchi Would you mind trying that? :-)

DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss");
String formattedDateTime = currentDateTime.format(formatter);

stringBuilder = new StringBuilder();
stringBuilder.append("== ");
stringBuilder.append("Feedback from ");
Expand Down Expand Up @@ -89,6 +95,10 @@ public void init() {
}
stringBuilder.append("~~~~");
stringBuilder.append("\n");
// adds Current Date & Time when a Feedback is created
stringBuilder.append("Generated on: " + formattedDateTime);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing this line with this

 stringBuilder.append("Generated on: ").append(formattedDateTime);

stringBuilder.append("\n");

}

@Override
Expand Down
Loading