Add license scan badge #759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Badge the README to show that we're complying with all the CNCF's license checks. Signed-off-by: Akshay Shah <[email protected]>
Verify that PRs don't introduce dependencies with problematic licenses. Signed-off-by: Akshay Shah <[email protected]>
Restrict action permissions and enumerate triggers. Signed-off-by: Akshay Shah <[email protected]>
mattrobenolt
approved these changes
Jun 25, 2024
|
The Fossa action is currently failing with permissions problems. I've reached out to our CNCF contacts to understand what we're supposed to do here. |
|
IIUC, we are now using Snyk, so we can close this. |
|
Correction: we are using Fossa (not Snyk), but we decided that we don't need the badges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CNCF requires that we adopt either Snyk or Fossa for license scanning. We tried Snyk, but it wasn't ideal - it bundles security and license scanning, and both were high-noise.
Fossa is much lower-noise. This project is already onboarded through the Fossa UI, with a clean bill of health. This PR contains some finishing touches: