Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesizer skips over embeddings file if model only has one speaker #2587

Merged

Conversation

wonkothesanest
Copy link
Contributor

It looks like the Neon model is special in that t does not have a speaker_name and it wants to get the only item available. This was blocking a valid model with one speaker and a d_vector_file from being executed to get the embedding.

It looks like the Neon model is special in that t does not have a speaker_name and it wants to get the only item available.
This was blocking a valid model with one speaker and a d_vector_file from being executed to get the embedding.

Leaving the check to be second still works fine for the case that there is only one model and no speaker name.

This is in reference to bug 2320
#2320

(updated from trying to get my author right)

…aker_name and it wants to get the only item available. This was blocking a valid model with one speaker and a d_vector_file from being executed to get the embedding.
@wonkothesanest wonkothesanest changed the title Synthesizer skips over embeddings file if model only has one speaker May 4, 2023
@wonkothesanest
Copy link
Contributor Author

wonkothesanest commented May 4, 2023

Can someone please guide me to some documentation on how to get the tests to pass? I believe there is not a correct token setup for Coqui TTS.
"No API token found for 🐸Coqui Studio voices - https://coqui.ai/ \n"

@erogol I'm sorry to bug you (and please take your time, I just wanted to tag you to make sure I wasn't expected to do something else). Do you have any tips for getting the tests to pass, do I need an API key?

TTS/utils/synthesizer.py Outdated Show resolved Hide resolved
@wonkothesanest
Copy link
Contributor Author

I have 5 failing tests all of which seem to have to do with not having a Coqui Studio Token. Can someone please help me understand how I might be able to fix this issue? I don't see where I could set the environment to add this token.

Relevant error message:

> Generator Model: multiband_melgan_generator
 > Discriminator Model: melgan_multiscale_discriminator
 > Text: This is an example.
 > Text splitted to sentences.
['This is an example.']
 > Processing time: 0.34621286392211914
 > Real-time factor: 0.15287555369838846
 > Saving output to /home/runner/work/TTS/TTS/tests/outputs/output.wav
 > Using 🐸Coqui Studio model:  coqui_studio/en/Torcull Diarmuid/coqui_studio
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.7.16/x64/bin/tts", line 8, in <module>
    sys.exit(main())
  File "/opt/hostedtoolcache/Python/3.7.16/x64/lib/python3.7/site-packages/TTS/bin/synthesize.py", line 330, in main
    api = TTS(model_name=args.model_name)
  File "/opt/hostedtoolcache/Python/3.7.16/x64/lib/python3.7/site-packages/TTS/api.py", line 285, in __init__
    self.load_tts_model_by_name(model_name, gpu)
  File "/opt/hostedtoolcache/Python/3.7.16/x64/lib/python3.7/site-packages/TTS/api.py", line 375, in load_tts_model_by_name
    self.csapi = CS_API()
  File "/opt/hostedtoolcache/Python/3.7.16/x64/lib/python3.7/site-packages/TTS/api.py", line 67, in __init__
    self._check_token()
  File "/opt/hostedtoolcache/Python/3.7.16/x64/lib/python3.7/site-packages/TTS/api.py", line 94, in _check_token
    "No API token found for 🐸Coqui Studio voices - https://coqui.ai/ \n"
ValueError: No API token found for 🐸Coqui Studio voices - https://coqui.ai/ 
Visit 🔗https://app.coqui.ai/account to get one.
Set it as an environment variable `export COQUI_STUDIO_TOKEN=<token>`

FAIL

@wonkothesanest
Copy link
Contributor Author

@erogol Anything else I need to do here for this PR?

@erogol
Copy link
Member

erogol commented Jun 21, 2023

@wonkothesanest thx for the PR. I'll review it as soon as I can

@wonkothesanest
Copy link
Contributor Author

@erogol
Anything else needed from me on this pr?

@stale
Copy link

stale bot commented Oct 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

@stale stale bot added the wontfix This will not be worked on but feel free to help. label Oct 14, 2023
@erogol erogol merged commit 13cd076 into coqui-ai:dev Oct 16, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on but feel free to help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants