-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SECDIR review #18
SECDIR review #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the changes that already were in 15-17 are the same.
Unaddressed:
"sum of the MACs" -> sum of the strengths...
(really: combining the strengths, because separate MACs can be attacked separately in general)
Now changed in 71c456f |
Now further addressed in e859cac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my concerns!
I have one more editorial proposal (see two suggestions below).
Co-authored-by: cabo <[email protected]>
Co-authored-by: cabo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hearing no objection I now merge this. |
This PR addresses the SECDIR review archived at https://mailarchive.ietf.org/arch/msg/secdir/6xBm7c_0kCzNtV16DM9vXuV3RF4/