feat(in-cluster): update example to use native crossplane way #190
Conversation
Signed-off-by: Christopher Haar <[email protected]>
Signed-off-by: Christopher Haar <[email protected]>
| @@ -0,0 +1,33 @@ | |||
| --- | |||
| apiVersion: pkg.crossplane.io/v1 | |||
There was a problem hiding this comment.
Would it make more sense/be easier to read if the resources are listed in the order that they need to be created? I know reconciliation will resolve ordering issues, but it might be more readable if it starts with ServiceAccount then ClusterRoleBinding then DeploymentRuntimeConfig and then Provider.
There was a problem hiding this comment.
Split the File only for ordered creation - can add it in one file with an comment
There was a problem hiding this comment.
We don't need to create the ServiceAccount - RuntimeConfig will create the ServiceAccount for you
| name: provider-kubernetes-cluster-admin | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: provider-kubernetes |
There was a problem hiding this comment.
The referenced Service Account is not created by this example - does it need to be for completeness?
There was a problem hiding this comment.
RuntimeConfig will create the ServiceAccount for you
Signed-off-by: Hasan Turken <[email protected]>
Description of your changes
use crossplane native way to grant a static service account the needed cluster-admin rights
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested