-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add LMS layout #405
base: master
Are you sure you want to change the base?
feat: add LMS layout #405
Conversation
src/v2/scss/layouts/_menu.scss
Outdated
@@ -1,6 +1,15 @@ | |||
$navbar-mobile-height: 48px; | |||
$navbar-submenu-height: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ни в коем случае не смешиваем реализации для внешнего сайта и внутреннего, потом устанем разделять их.
src/v2/scss/main.scss
Outdated
@@ -61,3 +62,5 @@ | |||
// TODO: Remove styles below from production build | |||
@import "pages/about"; | |||
@import "pages/principles"; | |||
|
|||
@import "lms/_main"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Разделяем целиком стили lms и внешнего сайта. В будущем у нас будет 3 репозитория: компоненты, внешний сайт, lms. Последние 2 будут переиспользовать только компоненты, но наследовать код у друг-друга точно не будут.
42483dc
to
7aff9ef
Compare
@@ -154,7 +154,8 @@ $grid-breakpoints: ( | |||
sm: 576px, | |||
md: 768px, | |||
lg: 992px, // XXX: Keep in sync with values from `v2/js/utils.js` | |||
xl: 1260px | |||
xl: 1260px, | |||
lms: 1222px // $grid-breakpoints(lg) + $sidebar-width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Есть несколько переменных только для lms, вынести их в отдельный файл lms/variables.scss
?
$zindex-popover: 1080; | ||
$zindex-tooltip: 1090; | ||
$zindex-close: 1100; | ||
$zindex-sidebar: 1050; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вот это тоже только для lms
@@ -0,0 +1,43 @@ | |||
$sidebar-width: 230px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тоже наверное в lms/variables.scss
нужно положить?
@@ -0,0 +1,194 @@ | |||
$navbar-submenu-height: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это правильная реализация независимого меню для lms?
Переполнение