Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support JSON columns in orderBy statement #184

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Apr 1, 2024

What's was changed

Adding support JSON columns in orderBy statement. For example:

$records = $this->database
    ->select()
    ->from('app_logs')
    ->orderBy('record->created_at', 'DESC')
    ->fetchAll();

Closes: #166

@msmakouz msmakouz added this to the 2.10.x milestone Apr 1, 2024
@msmakouz msmakouz requested a review from roxblnfk April 1, 2024 13:52
@msmakouz msmakouz self-assigned this Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (18bce1d) to head (ec3d1ed).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #184      +/-   ##
============================================
+ Coverage     95.28%   95.29%   +0.01%     
- Complexity     1843     1851       +8     
============================================
  Files           130      130              
  Lines          5085     5099      +14     
============================================
+ Hits           4845     4859      +14     
  Misses          240      240              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Driver/Compiler.php Outdated Show resolved Hide resolved
@msmakouz msmakouz merged commit b13a232 into 2.x Apr 3, 2024
41 checks passed
@msmakouz msmakouz deleted the feature/order-by-json branch April 3, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

💡 Add support json columns in orderBy statement
2 participants