fix: add parameter consideration when hashing the query part with orderBy #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmakouz
changed the title
msmakouz
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #206 +/- ##
============================================
+ Coverage 95.21% 95.33% +0.12%
- Complexity 1856 1859 +3
============================================
Files 130 130
Lines 5136 5143 +7
============================================
+ Hits 4890 4903 +13
+ Misses 246 240 -6 ☔ View full report in Codecov by Sentry. |
roxblnfk
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
The orderBy method can accept a
Cycle\Database\Injection\FragmentInterface. These can be instances of theCycle\Database\Injection\FragmentandCycle\Database\Injection\Expressionclasses. They may contain parameters, but these were not considered when hashing this part of the query. I added their consideration, similar to how it is done for the other parts of the query.