-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-a-spinner-at-least-until-some-messages-are-shown #1126
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure all tests pass successfully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You changed
Test: |
I changed loading_icon to loading_bar
I changed loading icon to loading bar to be very specific |
Okay, you also need to go change this in the unit tests at this line: |
@@ -650,7 +650,13 @@ class Hm_Output_loading_icon extends Hm_Output_Module { | |||
* Sort of ugly loading icon animated with js/css | |||
*/ | |||
protected function output() { | |||
return '<div class="loading_icon"></div>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You renamed the class here: class="loading_bar" but it was refering to the module: Hm_Output_loading_icon
you should keep it like that.
I'm trying to think of an example from which we can get an idea: nprogress Can you do something like that ? |
… some messages are shown
4a28fb4
to
945c5ff
Compare
As part of, or after Bootstrap 5: Cypht: Add a spinner at least until some messages are shown
In lists
For a message
Search
etc.