Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh lists after adding a account using New User Experience #1176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

henochit
Copy link
Member

Pullrequest

This fix allows the refresh of the server list after adding an account through the new user experience wizard.

@@ -57,7 +57,7 @@ var display_final_nux_step = function(res) {
}
);
} else {
Hm_Utils.redirect();
Hm_Utils.redirect('?page=servers');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at https://github.com/cypht-org/cypht/blob/master/modules/core/site.js#L1711 we have window.location.href that is already redirecting to the current URL of the page that is being displayed in the browser, in this case it will be www.domain.com?page= servers, even if we did not specify this parameter.

Have you had a case? I can't reproduce a one that redirects to an another page than servers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shadow243,
You’re right! After updating to the latest version of the master branch, I’m no longer able to reproduce the bug. Let me test various cases to ensure it's completely fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not reproduce this too... I have tried several time. @henochit have you tried too so we know...

@marclaporte
Copy link
Member

Once merged to master, please backport to 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants