Should be off by default | Address the controversial part in read rec… #1181
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once merged to master, please backport to 2.x |
marclaporte
added
the
blocker
Shadow243
force-pushed
the
mdn-dsn-turned-off-by-default
branch
from
f2890b9
to
9523cba
Compare
josaphatim
reviewed
Sep 12, 2024
modules/smtp/modules.php
Outdated
| @@ -407,6 +408,7 @@ public function process() { | |||
| $this->out('compose_draft', $draft); | |||
| } | |||
| $this->out('smtp_compose_type', $compose_type); | |||
| $this->out('user_settings', $settings); | |||
There was a problem hiding this comment.
Instead of passing the whole user_settings you can just pass enable_compose_delivery_receipt_setting
Shadow243
force-pushed
the
mdn-dsn-turned-off-by-default
branch
from
9523cba
to
3d01be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I turned off this feature((was: Cypht: MDN | DSN Missing in compose)) as a default setting as asked in 2024-05: #687