Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Move email: Enable drag-and-drop feature to move messages betwe… #1233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GedeonTS
Copy link
Member

@GedeonTS GedeonTS commented Sep 10, 2024

@GedeonTS GedeonTS changed the title [fIX] Move email: Enable drag-and-drop feature to move messages betwe… [FIX] Move email: Enable drag-and-drop feature to move messages betwe… Sep 10, 2024
@@ -2127,7 +2127,6 @@ if(tableBody && !hm_mobile()) {
sort: false,
group: 'messages',
ghostClass: 'drag_target',
draggable: ':not(.inline_msg)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GedeonTS how is removing this line supposed to fix the issue? That property ensures that emails can still be read in inline mode when requested instead of triggering the drag action.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line is the one that breaks the feature, what do you suggest? @jacob-js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GedeonTS you're basically removing this fix: #1034
I suggest first investigating the true cause of the issue, and then we can implement a proper fix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After more investigation I confirm that the true cause of the issue is #1034 @jacob-js , I suggest to revert it and find another alternative for it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so please work together to find another solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants