[FIX]hm-smtp.php: Declare properties to avoid deprecated dynamic prop… #1249
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erties creation in PHP 8.2+
Shadow243
reviewed
Oct 1, 2024
| @@ -408,7 +411,7 @@ function authenticate($username, $password, $mech) { | |||
| break; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
unnecessary change, please remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having :
[Sat Sep 21 17:30:09.314935 2024] [php:notice] [pid 7488:tid 1180] [client ::1:4662] PHP Deprecated: Creation of dynamic property Hm_SMTP::$supports_tls is deprecated in C:\\Apache24\\htdocs\\my_cypht\\modules\\smtp\\hm-smtp.php on line 134 [Sat Sep 21 17:30:09.314935 2024] [php:notice] [pid 7488:tid 1180] [client ::1:4662] PHP Deprecated: Creation of dynamic property Hm_SMTP::$supports_auth is deprecated in C:\\Apache24\\htdocs\\my_cypht\\modules\\smtp\\hm-smtp.php on line 135 [Sat Sep 21 17:30:09.314935 2024] [php:notice] [pid 7488:tid 1180] [client ::1:4662] PHP Deprecated: Creation of dynamic property Hm_SMTP::$max_message_size is deprecated in C:\\Apache24\\htdocs\\my_cypht\\modules\\smtp\\hm-smtp.php on line 148while trying to add an email from other provider with STARTTLS or unencrypted.Related PR