WIP: Strip objects optimisation #142
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied object types, dedupe on name/index (fref), it already has a type enumeration that could be used everywhere, binds, etc.
Remi remington was it you?
Well done.
|
To fix this more holistically then I probably want to wipe out the objects altogether / put on another layer and just use type + value with object wrapper being some other option or something. In some cases the user can happily avoid type because defaults / implicits and knowns will do the trick. |
joeyhub
commented
Feb 20, 2020
| CPP_DRIVER_DIR=$PHP_CASSANDRA | ||
| fi | ||
| else | ||
| for i in /usr/local /usr; do | ||
| if test -f $i/include/cassandra.h; then | ||
| if test -f $i/include/cassandra/cassandra.h; then |
There was a problem hiding this comment.
This needs some if then else for handling either situation (see remi merge).
|
I'm not sure if I'm going to finish this. I've stripped Cassandra from my tech stack entirely as it wasn't the appropriate solution to the problem so I'll no longer need to maintain this. |
|
Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress for removing object wrappage. This is the minimal I need for my use case but not yet appropriate for other use as it breaks BC and needs lib redesign to work with PHP properly.
The problem is other OOP languages with strict typing, etc such as C++, C# and Java, can probably box and unbox things but not so with PHP so the wrappage is a guaranteed RAM/CPU issue with the only want to optimise it to outright remove it.