OSS standardization changes #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
QMalcolm
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Howdy! Thank you so much for doing this work 🙂 I think we have some lines from contributing template that aren't applicable to this repository
martynydbt
reviewed
Dec 6, 2023
CONTRIBUTING.md
Outdated
|
|
||
| Once all tests are passing and your PR has been approved, a `dbt-docs` maintainer will merge your changes into the active development branch. And that's it! Happy developing :tada: | ||
|
|
||
| Sometimes, the content license agreement auto-check bot doesn't find a user's entry in its roster. If you need to force a rerun, add `@cla-bot check` in a comment on the pull request. |
There was a problem hiding this comment.
same about possibly adding a troubleshooting header. not blocking
martynydbt
reviewed
Dec 6, 2023
| attributes: | ||
| label: Context | ||
| description: | | ||
| Provide the "why", motivation, and alternative approaches considered -- linking to previous refinement issues, spikes, Notion docs as appropriate |
There was a problem hiding this comment.
spikes, docs as appropriate
Worth dropping the Notion reference since that is an implementation detail? Then if we ever moved off of Notion we wouldn't have to update this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-core#9221
Description
add contributing doc and dependabot alerts, modify readme to bring this OSS repo up to the minimal standards for OSS at dbt Labs.
I am unsure of the impact turning on dependabot will have. We will need to revisit once it's been on and we see what it generates.
Checklist
changie newto create a changelog entry