Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt: add real atoms select in c++ interface #3375

Merged
merged 137 commits into from
Mar 1, 2024

Conversation

CaRoLZhangxy
Copy link
Collaborator

select real atoms may be merged in DeepPot class for both backends in the future.

CaRoLZhangxy and others added 30 commits January 22, 2024 18:40
@CaRoLZhangxy CaRoLZhangxy marked this pull request as draft March 1, 2024 04:45
@CaRoLZhangxy CaRoLZhangxy marked this pull request as ready for review March 1, 2024 04:48
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.07%. Comparing base (54efc03) to head (d2532e8).
Report is 2 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3375      +/-   ##
==========================================
+ Coverage   76.06%   76.07%   +0.01%     
==========================================
  Files         421      420       -1     
  Lines       35514    35528      +14     
  Branches     1618     1620       +2     
==========================================
+ Hits        27013    27028      +15     
+ Misses       7633     7632       -1     
  Partials      868      868              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CaRoLZhangxy CaRoLZhangxy requested review from njzjz and wanghan-iapcm and removed request for njzjz March 1, 2024 07:02
Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Mar 1, 2024
Merged via the queue into deepmodeling:devel with commit ee8b82b Mar 1, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants