fix: unpin h5py on aarch64

[njzjz]

Fix #3864.

Summary by CodeRabbit

• New Features

  • Enhanced logic for detecting TensorFlow installation paths and requirements.
  • Improved error handling for TensorFlow version detection.

• Bug Fixes

  • Adjusted compatibility specifications for the h5py dependency on aarch64 architecture.

• Documentation

  • Updated comments to clarify changes in TensorFlow detection and compatibility issues.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes primarily involve updates to the TensorFlow detection logic in backend/find_tensorflow.py and modifications to dependency specifications in pyproject.toml. The updates enhance the handling of TensorFlow installation paths and refine version requirements for TensorFlow and h5py, particularly for the aarch64 architecture. The adjustments aim to improve compatibility and error handling in the TensorFlow integration process.

Changes

Files	Change Summary
backend/find_tensorflow.py	Updated logic for finding TensorFlow, including checks for the TENSORFLOW_ROOT variable and refined version requirements for TensorFlow and h5py. Function signatures were modified for clarity and updated error handling was maintained.
pyproject.toml	Adjusted the upper bound for the h5py dependency from <3.11.0 to !=3.11.0 for the aarch64 architecture. Other project metadata and optional dependencies remained unchanged.

Assessment against linked issues

Objective	Addressed	Explanation
Unpin h5py on aarch64 ( #3864 )	✅

Suggested labels

upstream

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ad8bebe and 8b6089b.

📒 Files selected for processing (2)

• backend/find_tensorflow.py (1 hunks)
• pyproject.toml (1 hunks)

🔇 Additional comments (2)

pyproject.toml (1)

47-47: LGTM! Verify compatibility with the latest h5py version.

The change successfully unpins h5py for aarch64 architecture on Linux systems, allowing versions >= 3.6.0 except for 3.11.0. This aligns with the PR objectives and enables the use of newer h5py versions, including the first one providing wheels for aarch64.

To ensure compatibility with the latest h5py version, please run the following verification script:

backend/find_tensorflow.py (1)

159-160: Verify the necessity of excluding h5py version 3.11.0

You have excluded h5py version 3.11.0 in the requirements for Linux on aarch64 (!=3.11.0). Please verify if this exclusion is still required, or if h5py 3.11.0 is now compatible on this platform.

Also applies to: 167-167

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.46%. Comparing base (ad8bebe) to head (8b6089b).
Report is 1 commits behind head on devel.

Additional details and impacted files

@@           Coverage Diff           @@
##            devel    #4176   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files         537      537           
  Lines       52168    52168           
  Branches     3046     3046           
=======================================
  Hits        43543    43543           
  Misses       7678     7678           
  Partials      947      947           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.